User select in UI feature #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
app/api/chemotion/admin_user_api.rb
Outdated
| desc 'Find top (5) matched user by name and by type' | ||
| params do | ||
| requires :name, type: String, desc: 'user name' | ||
| optional :type, type: Array[String], desc: 'user types', |
There was a problem hiding this comment.
Style/RedundantArrayConstructor: Remove the redundant Array constructor.
app/api/chemotion/user_api.rb
Outdated
| @@ -5,14 +5,14 @@ class UserAPI < Grape::API | |||
| desc 'Find top 3 matched user names' | |||
| params do | |||
| requires :name, type: String | |||
| optional :type, type: Array[String], desc: 'user types', | |||
There was a problem hiding this comment.
Style/RedundantArrayConstructor: Remove the redundant Array constructor.
| it 'returns a response with an array of people' do | ||
| expect(parsed_json_response['users']).to include(person_obj) | ||
| end | ||
| end |
There was a problem hiding this comment.
RSpec/EmptyLineAfterExampleGroup: Add an empty line after describe.
adapt corresponding non admin endpoint to use user simple entity
remove deprecated fetcher
PiTrem
force-pushed
the
user-select-in-ui-feature
branch
from
df27243
to
a8c3fec
Compare
LCOV of commit
|
FabianMauz
requested changes
Jun 30, 2023
PiTrem
force-pushed
the
user-select-in-ui-feature
branch
from
7a2d5bf
to
0c09a07
Compare
LCOV of commit
|
FabianMauz
approved these changes
Jun 30, 2023
| @@ -186,7 +186,7 @@ export default class AdminFetcher { | |||
| } | |||
|
|
|||
| static fetchUsersByNameType(name, type, limit = 5) { | |||
| return fetch(`/api/v1/admin_user/listUsers/byname.json?type=${type}&name=${name}&limit=${limit}`, { | |||
| return fetch(`/api/v1/admin_user/listUsers/byname.json?${new URLSearchParams({ name, type, limit })}`, { | |||
There was a problem hiding this comment.
cool, if naming the variable as the parameter makes it may more easier
PiTrem
added a commit
that referenced
this pull request
Jul 7, 2023
* remove duplicated admin api endpoint also adapt equivalent non admin endpoint to use user simple entity * extract react select option formatting to utility function * remove deprecated fetcher
mekkyz
pushed a commit
that referenced
this pull request
Sep 21, 2023
* remove duplicated admin api endpoint also adapt equivalent non admin endpoint to use user simple entity * extract react select option formatting to utility function * remove deprecated fetcher
baolanlequang
pushed a commit
that referenced
this pull request
Mar 5, 2024
* remove duplicated admin api endpoint also adapt equivalent non admin endpoint to use user simple entity * extract react select option formatting to utility function * remove deprecated fetcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify user-find-by-name api endpoint:
resolve #1384