Unify datetime format #1389
Merged
Unify datetime format #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -5,6 +5,7 @@ class ApplicationEntity < Grape::Entity | |||
| CUSTOM_ENTITY_OPTIONS = %i[anonymize_below anonymize_with].freeze | |||
|
|
|||
| format_with(:eln_timestamp) do |datetime| | |||
| #datetime.present? ? I18n.l(datetime, format: :eln_iso8601) : nil | |||
There was a problem hiding this comment.
Layout/LeadingCommentSpace: Missing space after #.
PiTrem
force-pushed
the
unify-datetime-format
branch
2 times, most recently
from
b6ec01d
to
b6037ab
Compare
PiTrem
force-pushed
the
unify-datetime-format
branch
from
b6037ab
to
6c02238
Compare
| @@ -20,5 +20,13 @@ class DeviceMetadataEntity < Grape::Entity | |||
| expose :data_cite_created_at, documentation: { type: 'DateTime', desc: 'created_at DataCite ' } | |||
| expose :data_cite_updated_at, documentation: { type: 'DateTime', desc: 'updated_at DataCite' } | |||
| expose :data_cite_version, documentation: { type: 'Integer', desc: 'version at DataCite' } | |||
|
|
|||
| def data_cite_created_at | |||
| object.data_cite_created_at.present? ? && I18n.l(object.data_cite_created_at, format: :eln_timestamp) : nil | |||
There was a problem hiding this comment.
Lint/Syntax: unexpected token tAMPER
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter, under AllCops)
| @@ -20,5 +20,13 @@ class DeviceMetadataEntity < Grape::Entity | |||
| expose :data_cite_created_at, documentation: { type: 'DateTime', desc: 'created_at DataCite ' } | |||
| expose :data_cite_updated_at, documentation: { type: 'DateTime', desc: 'updated_at DataCite' } | |||
| expose :data_cite_version, documentation: { type: 'Integer', desc: 'version at DataCite' } | |||
|
|
|||
| def data_cite_created_at | |||
| object.data_cite_created_at.present? ? && I18n.l(object.data_cite_created_at, format: :eln_timestamp) : nil | |||
There was a problem hiding this comment.
Lint/Syntax: unexpected token tCOLON
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter, under AllCops)
| end | ||
|
|
||
| def data_cite_updated_at | ||
| object.data_cite_updated_at.present? ? && I18n.l(object.data_cite_updated_at, format: :eln_timestamp) : nil |
There was a problem hiding this comment.
Lint/Syntax: unexpected token tAMPER
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter, under AllCops)
| end | ||
|
|
||
| def data_cite_updated_at | ||
| object.data_cite_updated_at.present? ? && I18n.l(object.data_cite_updated_at, format: :eln_timestamp) : nil |
There was a problem hiding this comment.
Lint/Syntax: unexpected token tCOLON
(Using Ruby 2.7 parser; configure using TargetRubyVersion parameter, under AllCops)
PiTrem
force-pushed
the
unify-datetime-format
branch
from
6c02238
to
f176352
Compare
LCOV of commit
|
PiTrem
force-pushed
the
unify-datetime-format
branch
from
f176352
to
7ac1cc0
Compare
FabianMauz
approved these changes
Jul 4, 2023
app/api/chemotion/message_api.rb
Outdated
There was a problem hiding this comment.
checked if response of endpoint is not used any more. Can confirm it.
It is harvested by MessagesFetcher.createMessage but then in further processing thrown away:
MessagePublish.js line 51
UserManagement.js line 453
LCOV of commit
|
Also use short format date llll, not LLLL.
PiTrem
force-pushed
the
unify-datetime-format
branch
from
7ac1cc0
to
ffb5661
Compare
LCOV of commit
|
mekkyz
pushed a commit
that referenced
this pull request
Sep 21, 2023
* use formatDate utility to format displayed timestamps (reduce the number of 'import moment.js' ) * fix Intl time format * Entities: use default timestamp formatter * timezoneHelper: default to iso format if parsed value invalid. Also use short format date llll, not LLLL. TODO use locale ?
baolanlequang
pushed a commit
that referenced
this pull request
Mar 5, 2024
* use formatDate utility to format displayed timestamps (reduce the number of 'import moment.js' ) * fix Intl time format * Entities: use default timestamp formatter * timezoneHelper: default to iso format if parsed value invalid. Also use short format date llll, not LLLL. TODO use locale ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use formatDate utility to format displayed timestamps
(reduce the number of 'import moment.js' )
Entity: return time zone in timestamp
more entities are now using the same exposure (expose_timestamp) for timestamps
shoudl resolve timezone diff in comment-feature and notification-feature