Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates in calendar feature re-formatted #1391

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

f-idiris
Copy link
Contributor

@f-idiris f-idiris commented Jul 4, 2023

The dates formats for the different tabs in the calendar feature have been updated so they are consistent (i.e. ddd DD MMMM YYYY).

  • rather 1-story 1-commit than sub-atomic commits

  • commit title is meaningful => git history search

  • commit description is helpful => helps the reviewer to understand the changes

  • code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured

  • added code is linted

  • tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited

  • in case the changes are visible to the end-user,  video or screenshots should be added to the PR => helps with user testing

  • testing coverage improvement is improved.

  • CHANGELOG :  add a bullet point on top (optional: reference to github issue/PR )

  • parallele PR for documentation  on docusaurus  if the feature/fix is tagged for a release

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

LCOV of commit e53e9e8 during Continuous Integration #1235

Summary coverage rate:
  lines......: 59.4% (12269 of 20659 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@PiTrem PiTrem merged commit 565238d into main Jul 4, 2023
3 checks passed
mekkyz pushed a commit that referenced this pull request Sep 21, 2023
baolanlequang pushed a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants