Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make height of sampleInfo row auto to fix styling bug for sample Tab… #1395

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

adambasha0
Copy link
Contributor

@adambasha0 adambasha0 commented Jul 6, 2023

… bar

  • rather 1-story 1-commit than sub-atomic commits

  • commit title is meaningful => git history search

  • commit description is helpful => helps the reviewer to understand the changes

  • code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured

  • added code is linted

  • tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited

  • in case the changes are visible to the end-user,  video or screenshots should be added to the PR => helps with user testing

  • testing coverage improvement is improved.

  • CHANGELOG :  add a bullet point on top (optional: reference to github issue/PR )

  • parallele PR for documentation  on docusaurus  if the feature/fix is tagged for a release

@adambasha0 adambasha0 linked an issue Jul 6, 2023 that may be closed by this pull request
@adambasha0 adambasha0 self-assigned this Jul 6, 2023
@adambasha0 adambasha0 requested a review from PiTrem July 6, 2023 12:20
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

LCOV of commit 734fbdc during Continuous Integration #1250

Summary coverage rate:
  lines......: 59.4% (12268 of 20649 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@PiTrem PiTrem merged commit 54872ff into main Jul 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.5: Tab bar in sample details pane is off
2 participants