Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync chemspectra nmrium eln v173 #1513

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

baolanlequang
Copy link
Member

@baolanlequang baolanlequang commented Sep 1, 2023

  • rather 1-story 1-commit than sub-atomic commits

  • commit title is meaningful => git history search

  • commit description is helpful => helps the reviewer to understand the changes

  • code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured

  • added code is linted

  • tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited

  • in case the changes are visible to the end-user,  video or screenshots should be added to the PR => helps with user testing

  • testing coverage improvement is improved.

  • CHANGELOG :  add a bullet point on top (optional: reference to github issue/PR )

  • parallele PR for documentation  on docusaurus  if the feature/fix is tagged for a release

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

LCOV of commit 85994b1 during Continuous Integration #1674

Summary coverage rate:
  lines......: 59.9% (12439 of 20780 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

LCOV of commit 3fc54ef during Continuous Integration #1675

Summary coverage rate:
  lines......: 59.8% (12424 of 20779 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@baolanlequang baolanlequang force-pushed the fix-sync-chemspectra-nmrium-eln-v173 branch from 3fc54ef to 8813537 Compare September 5, 2023 07:42
@baolanlequang baolanlequang marked this pull request as ready for review September 5, 2023 07:42
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

LCOV of commit 8813537 during Continuous Integration #1681

Summary coverage rate:
  lines......: 59.8% (12436 of 20780 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@phuang26 phuang26 merged commit 74215eb into main Sep 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants