1672 option to save dataset in attachments modal #1831
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baolanlequang
force-pushed
the
1672-option-to-save-dataset-in-attachments-modal
branch
3 times, most recently
from
b239452
to
9997a1a
Compare
LCOV of commit
|
baolanlequang
force-pushed
the
1672-option-to-save-dataset-in-attachments-modal
branch
from
f0f7d6b
to
cbabd5b
Compare
LCOV of commit
|
LCOV of commit
|
baolanlequang
force-pushed
the
1672-option-to-save-dataset-in-attachments-modal
branch
from
cbabd5b
to
209c8df
Compare
LCOV of commit
|
LCOV of commit
|
baolanlequang
force-pushed
the
1672-option-to-save-dataset-in-attachments-modal
branch
from
e33e7a0
to
f923c46
Compare
LCOV of commit
|
baolanlequang
force-pushed
the
1672-option-to-save-dataset-in-attachments-modal
branch
3 times, most recently
from
b9f7f6a
to
532a787
Compare
LCOV of commit
|
|
Demo video for new changes Screencast.2024-04-03.13.19.02.mp4 |
|
The change is described in this image
The changed flow is described in this file https://drive.google.com/file/d/1P6ge8BxSROhKfc9ajhTw5hT52FsyrNZL/view?usp=sharing |
PiTrem
added a commit
that referenced
this pull request
Apr 9, 2024
Squashed commit of the following: commit 532a787 Author: Lan Le <lan.le@kit.edu> Date: Thu Mar 21 11:36:28 2024 +0100 feat: change flow to save updated attachment
PiTrem
added a commit
that referenced
this pull request
Apr 9, 2024
Squashed commit of the following: commit 532a787 Author: Lan Le <lan.le@kit.edu> Date: Thu Mar 21 11:36:28 2024 +0100 feat: change flow to save updated attachment
PiTrem
added a commit
that referenced
this pull request
Apr 16, 2024
Squashed commit of the following: commit 532a787 Author: Lan Le <lan.le@kit.edu> Date: Thu Mar 21 11:36:28 2024 +0100 feat: change flow to save updated attachment
baolanlequang
force-pushed
the
1672-option-to-save-dataset-in-attachments-modal
branch
from
532a787
to
4633a6f
Compare
baolanlequang
force-pushed
the
1672-option-to-save-dataset-in-attachments-modal
branch
from
4633a6f
to
0d3b5b2
Compare
LCOV of commit
|
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release