Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix element refresh on change collection #293

Merged
merged 1 commit into from
Nov 15, 2016

Conversation

Sergeykot
Copy link
Contributor

No description provided.

@Sergeykot
Copy link
Contributor Author

Alternative solution is to check if the current element if the same that we get from server and not update it in order not to loose the data

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a42e7ab on fix-element-refresh-on-collection-change into * on master*.

@Sergeykot Sergeykot force-pushed the fix-element-refresh-on-collection-change branch from a42e7ab to f57ad47 Compare November 14, 2016 16:03
@Sergeykot
Copy link
Contributor Author

code updated

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f57ad47 on fix-element-refresh-on-collection-change into * on master*.

@Sergeykot
Copy link
Contributor Author

ok this solution works. however when I investigated a bit found that I can fix the method componentWillReceiveProps to reaction and it fixes the behaviour of it. However for sample same method does not work. I would suggest to merge this solution

@Sergeykot
Copy link
Contributor Author

ok this to be refactored by me now, please do not merge

@PiTrem PiTrem merged commit f31a302 into master Nov 15, 2016
@PiTrem PiTrem deleted the fix-element-refresh-on-collection-change branch November 15, 2016 08:49
PiTrem added a commit that referenced this pull request Nov 17, 2017
…ined' into 'development'

correct js custom_info compare logic

Closes #293

See merge request ComPlat/chemotion_ELN!503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants