Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling #1

Closed
Comandeer opened this issue Jun 22, 2022 · 0 comments · Fixed by #4
Closed

Better error handling #1

Comandeer opened this issue Jun 22, 2022 · 0 comments · Fixed by #4
Labels
enhancement New feature or request
Milestone
v0.2.0

Comments

@Comandeer
Copy link
Owner

Currently esmlm binary throws an error if the executed command fails. Probably it would be better to just pipe the whole output to the main process and exit with the exit code of the child process, without the additional error being thrown.
@Comandeer Comandeer added the enhancement New feature or request label Jun 22, 2022
@Comandeer Comandeer added this to the v0.2.0 milestone Jun 22, 2022
@Comandeer Comandeer mentioned this issue Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Improve error handling Comandeer/esm-loader-manager
1 participant
@Comandeer