[Bug]: Unable to shoot through Medieval Overhaul (MO) Castle Embrasures

[arvalaan]

Specifications
Rimworld version: 1.3.3389
Combat Extended version: Latest Dev Snapshot as of 2nd of August 17:51 GMT+2
Combat Extended source (Steam, GitHub, etc.): GitHub
Your operating system: Windows 11
Your mod list: Harmony, Core, Royalty, Ideology, HugsLib, LWM's Deep Storage, Vanilla Expanded Framework, [SYR] Processor Framework, Medieval Overhaul, Combat Extended

Description
A pawn, equipped with a War Bow and Great Arrows is not shooting at pawns he/she is targeting when standing behind Castle Embrasures.

Expected behavior
Expected the Castle Embrasure to function the same as the CE Embrasures, namely that a Pawn can shoot when taking cover behind it.

To reproduce
Use the above-mentioned mod list, position Pawn with War Bow and Arrows behind Castle Embrasure, then target (friendly) other pawn and observe; nothing happens.
Screenshots & log dumps


(Clementine was not harmed in this process)

No errors are popping up.

Complete the following checklist
I hereby verify that I have done the following:

• Confirmed that my game version and load order are correct.
• Confirmed that I am running the appropriate and most updated version of Combat Extended and required compatibility patches.
• Confirmed I am not running any mods with known incompatibilities with Combat Extended.
• Disabled Combat Extended and attempted to reproduce the behavior without success.

[mountainofcheezo]

I have the same issue.

[ANA7332]

Same.

[arvalaan]

I fixed it myself by adding a new XML file to the Medieval Overhaul patch filed in Combat Extended.

Path: SteamLibrary\steamapps\common\RimWorld\Mods\CombatExtended\Patches\Medieval Overhaul\MO_Buildings.xml

Contents:

<?xml version="1.0" encoding="utf-8" ?>
<Patch>

  <Operation Class="PatchOperationFindMod">
    <mods>
      <li>Medieval Overhaul</li>
    </mods>
    <match Class="PatchOperationSequence">
      <operations>

                
        <li Class="PatchOperationReplace">
            <xpath>Defs/ThingDef[defName="DankPyon_CastleWallEmbrasures"]/fillPercent</xpath>
            <value>
                <fillPercent>0.7</fillPercent>      
            </value>
        </li>

        </operations>
	</match>
	</Operation>

</Patch>

The issue here being that the Castle Embrasures are too high (apparently). This patches them to be the same height as the embrasures that are included in CE.

[ANA7332]

I fixed it myself by adding a new XML file to the Medieval Overhaul patch filed in Combat Extended.

Path: SteamLibrary\steamapps\common\RimWorld\Mods\CombatExtended\Patches\Medieval Overhaul\MO_Buildings.xml

Contents:

<?xml version="1.0" encoding="utf-8" ?>
<Patch>

  <Operation Class="PatchOperationFindMod">
    <mods>
      <li>Medieval Overhaul</li>
    </mods>
    <match Class="PatchOperationSequence">
      <operations>

                
        <li Class="PatchOperationReplace">
            <xpath>Defs/ThingDef[defName="DankPyon_CastleWallEmbrasures"]/fillPercent</xpath>
            <value>
                <fillPercent>0.7</fillPercent>      
            </value>
        </li>

        </operations>
	</match>
	</Operation>

</Patch>

The issue here being that the Castle Embrasures are too high (apparently). This patches them to be the same height as the embrasures that are included in CE.

Thanks!