Share replay leak #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jasdev - mind looking into this, as you know ReplaySubject well enough here? Thanks @jabeattie :) |
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 97.10% 97.12% +0.01%
==========================================
Files 62 62
Lines 3315 3336 +21
==========================================
+ Hits 3219 3240 +21
Misses 96 96
Continue to review full report at Codecov.
|
jasdev
approved these changes
Apr 4, 2021
There was a problem hiding this comment.
Thanks for PRing this @jabeattie! Looks good to me after a read through — really appreciate you adding a test to verify the fix. ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #85
I added a test that proved that the source publisher was retained after everything had been nilled out/released.
I then added the
cancel()method call in theforwardCompletionToBuffermethod inside ReplaySubject.Subscription as this causes the subscription to then be released.As I mentioned in the issue I raised, I'm not familiar enough to know what the other implications of this could be (it seems to all work fine for me in my project) so would appreciate any help or comments.