Fix "Received value before receiving subscription" crash. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epatey
force-pushed
the
fix_value_before_subscription
branch
from
22edcec
to
9a5b8a1
Compare
|
Switched implementation to use |
freak4pc
reviewed
Jun 26, 2019
… being subscribed to. Combine requires receiving the subscription event before receiving and value events.
epatey
force-pushed
the
fix_value_before_subscription
branch
from
9a5b8a1
to
295148a
Compare
freak4pc
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the code. Appreciate you sharing your work.
Fix crash caused by Observables that send a value synchronously while being subscribed to. Combine requires receiving the subscription event before receiving and value events.