Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User manager breaks when combo enabled #79

Open
listerr opened this issue Feb 22, 2024 · 9 comments
Open

User manager breaks when combo enabled #79

listerr opened this issue Feb 22, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@listerr
Copy link

listerr commented Feb 22, 2024

I've updated to the current version.

When I try to use the user manager to edit of find a user, I get this error:-

2024-02-22 11:41:38 /var/www/bwra.org.uk/lib/plugins/combo/ComboStrap/ExecutionContext.php(223) E_ERROR: Allowed memory size of 134217728 bytes exhausted (tried to allocate 135168 bytes)
#0 [internal function]: dokuwiki\ErrorHandler::fatalShutdown()
#1 {main}

If I disable Combo plugin, user manager works okay.

I have about 40 users on the system.

@listerr
Copy link
Author

listerr commented Feb 22, 2024

I tried to increase the php memory_limit:

; Maximum amount of memory a script may consume
; http://php.net/memory-limit
memory_limit = 512M

And restart everything, but doesn't change anything...

@gerardnico
Copy link
Member

gerardnico commented Feb 22, 2024

User manager ... ???

I don't touch it at all. I'm going to try also.

@listerr
Copy link
Author

listerr commented Feb 22, 2024 via email

gerardnico added a commit that referenced this issue Feb 22, 2024
…that are logged if unknown. This log also creating a context, creating a infinite loop. We broke the loop by checking the presence of the context.
@gerardnico
Copy link
Member

Sorry. I found it. This is because of an infinite loop.

I just made a commit. If you update Combo, it should work now.
https://combostrap.com/release/how-to-update-combo-or-a-third-party-plugin-in65c0ya#how_to_update_the_combo_plugin

To be precise, the admin page had an unknown parameter and it happened that combo was logging it.
During this logging, the creation of combo was started again, making an infinite loop.

Thanks Rob for the feedback
Sorry for the inconvenience.
Nico

@gerardnico
Copy link
Member

I have installed the patch on Combostrap.com and it works. Unfortunately, there is a false warning now. May I should not show any warning on admin page.

@gerardnico gerardnico reopened this Feb 22, 2024
@gerardnico gerardnico added this to the 1.25.3 milestone Feb 22, 2024
@gerardnico gerardnico added the enhancement New feature or request label Feb 22, 2024
@gerardnico gerardnico self-assigned this Feb 22, 2024
@listerr
Copy link
Author

listerr commented Feb 26, 2024

It seemed to work after that update. But unfortunately there we too many breaking layout changes in the new Combo that I need to go through the whole site and work out how to fix. Error messages popping up about various markup that's deprecated or changed. I have had to revert everything from backups for now and just upgrade DW itself, until I can find the time to sort out all the layout issues!

@gerardnico
Copy link
Member

Thanks rob.

They are just deprecation notice due to new features. The pages should work.

Unfortunatey with php and dokuwiki, modifying the pages automatically is not possible.

@listerr
Copy link
Author

listerr commented Feb 26, 2024

Hmm. After the upgrade, it seemed to make quite a mess of my site for various reasons.

Also I've used NOTOC frequently and I don't like the default numbered headings and various other things which don't look right. I seems to add a TOC whether I want it or not.

Also I have to fix a bunch of pages where I've used template variables etc.

@gerardnico
Copy link
Member

Sorry for that. It’s pretty difficult to test all options. If I can help, let me know.

in the last version, there is a template engine by page. By choosing the template you include or not the toc.
https://combostrap.com/theme/what-is-a-template-z9tl87hg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants