Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce functionality to also get only the new part for HTML mails. #1

Closed
wants to merge 1 commit into from
Closed

Introduce functionality to also get only the new part for HTML mails. #1

wants to merge 1 commit into from

Conversation

Hipska
Copy link
Collaborator

@Hipska Hipska commented Apr 17, 2019

No description provided.

@piRGoif
Copy link
Contributor

piRGoif commented May 21, 2019

Hello Thomas, thanks for this contribution.

Could you provide some examples to see this in action ? There are lots of existing one in the log directory, you can add yours in there.

Also we are not very confident to change the default and historic behavior... You should add a parameter to activate your new behavior, this parameter would disabled it by default.

@piRGoif piRGoif closed this Apr 6, 2020
@Hipska
Copy link
Collaborator Author

Hipska commented Apr 6, 2020

Oh, why is it closed? I did not see this comment, so sorry for not responding earlier.

As you see in the code, my additions are configurable. The only thing is that default behaviour is not disabled. I can add this if wanted.

@piRGoif
Copy link
Contributor

piRGoif commented Apr 6, 2020

Hello Thomas,
Very sorry, I did not close explicitly this PR...
I delete the develop branch though, so it might have triggered a close of all PR on this branch ?
You can open a new PR as a copy of this one, but don't forget to add examples as requested on may last year O:)

@Hipska
Copy link
Collaborator Author

Hipska commented Apr 7, 2020

Why removing the develop branch? Isn't there anymore development on this going to happen?

@piRGoif
Copy link
Contributor

piRGoif commented Apr 7, 2020

When we migrated our code to GitHub during summer 2018, we decided to use GitFlow for our modules as well as in the iTop repo.
But two years later we see that modules don't need it at all ! So we're sticking with only 1 branch, that is master. Some modules may have a support branch when needed, but there are very few of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
2 participants