Added code to create a file that indicates Maintenance Mode #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cholcombe973
requested changes
Aug 30, 2019
…or removing Maintenance flag file
|
Changed SetMaintenance subcommand to set_maintenance |
|
Added additional code to remove the set maintenance status. |
sdandam
requested changes
Sep 6, 2019
src/client.rs
Outdated
| trace!("handle_set_maintenance called"); | ||
| helpers::set_maintenance(s)?; | ||
| trace!("handle_set_maintenance finished"); | ||
|
|
There was a problem hiding this comment.
nit: extra line can be removed
src/client.rs
Outdated
| trace!("handle_unset_maintenance called"); | ||
| helpers::unset_maintenance(s)?; | ||
| trace!("handle_unset_maintenance finished"); | ||
|
|
There was a problem hiding this comment.
nit: extra line can be removed
src/disk_manager.rs
Outdated
| result.set_result(ResultType::OK); | ||
| } | ||
| Err(..) => { | ||
| result.set_result(ResultType::ERR); |
There was a problem hiding this comment.
I think an error string should also be set here, so that the caller/client knows the reason why the operation failed
src/disk_manager.rs
Outdated
| result.set_result(ResultType::OK); | ||
| } | ||
| Err(..) => { | ||
| result.set_result(ResultType::ERR); |
There was a problem hiding this comment.
error string should be set here too.
|
|
||
| pub fn set_maintenance(s: &mut Socket) -> BynarResult<()>{ | ||
| let mut result = OpResult::new(); | ||
| let file = match File::create("/var/log/setMaintenance.lock") { |
There was a problem hiding this comment.
This file location should be read from the config file
| } | ||
| pub fn unset_maintenance(s: &mut Socket) -> BynarResult<()>{ | ||
| let mut result = OpResult::new(); | ||
| let file = match fs::remove_file("/var/log/setMaintenance.lock") { |
There was a problem hiding this comment.
This file location should be read from config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.