Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Blog JavaScript errors #211

Closed
JohnRiv opened this issue Dec 19, 2018 · 1 comment
Closed

Fix Blog JavaScript errors #211

JohnRiv opened this issue Dec 19, 2018 · 1 comment
Labels
hacktoberfest

Comments

@JohnRiv
Copy link
Member

JohnRiv commented Dec 19, 2018

If you open the browser developer console when visiting https://comcast.github.io/blog.html, you'll notice there are a handful of JS errors... probably the easiest approach is to create a separate bundle for the JS for that page that only includes the basic analytics code
@annania annania mentioned this issue May 14, 2019
Closed
@yq314 yq314 mentioned this issue Oct 1, 2019
Closed
@carlism
Copy link
Member

carlism commented Oct 2, 2019

@yq314 Thanks for the contribution!

@carlism carlism closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove javascript.js as blog doesn't need it
3 participants
@carlism @JohnRiv @shillasaebi