Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove javascript.js as blog doesn't need it #245

Closed
wants to merge 1 commit into from
Closed

remove javascript.js as blog doesn't need it #245

wants to merge 1 commit into from

Conversation

yq314
Copy link
Contributor

@yq314 yq314 commented Oct 1, 2019

This PR fixes https://github.com/Comcast/Comcast.github.io/issues/211, blog.html doesn't use javascript so it's safe to remove.

This PR fixes https://github.com/Comcast/Comcast.github.io/issues/211, `blog.html` doesn't use javascript so it's safe to remove.
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2019

CLA assistant check
All committers have signed the CLA.

@shillasaebi
Copy link
Member

Thank you so much for contributing to this project. Happy Hacktoberfest!

@shillasaebi shillasaebi closed this Oct 1, 2019
@yq314
Copy link
Contributor Author

yq314 commented Oct 1, 2019

Hmm I guess it was a mistake to close instead of merge?

@carlism
Copy link
Member

carlism commented Oct 1, 2019

Yes, this was a mistake. Unfortunately, I can't find a way to re-open it. We may need you to open another PR. Sorry.

@yq314 yq314 mentioned this pull request Oct 1, 2019
@yq314
Copy link
Contributor Author

yq314 commented Oct 1, 2019

okay opened again in https://github.com/Comcast/Comcast.github.io/pull/247 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Blog JavaScript errors
4 participants