Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add ability to choose ports through command line arguments #5

Closed
alextarasov1 opened this issue Sep 27, 2019 · 3 comments · Fixed by #11
Closed

[Feature] Add ability to choose ports through command line arguments #5

alextarasov1 opened this issue Sep 27, 2019 · 3 comments · Fixed by #11
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@alextarasov1
Copy link
Collaborator

Problem

Right now, ports are hardcoded to be 9999 for proxy and 9998 for exposed API.
This should be configurable because sometimes these ports might already be in use.

Feature Description

Add ability to choose ports through command line arguments. This applies for both the proxy and exposed api. It should be possible to configure both ports independently.

Additional Context

Dockerfile needs to be updated to account for these changes, as well as the makefile.
@alextarasov1 alextarasov1 mentioned this issue Sep 27, 2019
Open
@alextarasov1 alextarasov1 added good first issue Good for newcomers hacktoberfest enhancement New feature or request labels Sep 27, 2019
@Silvyre
Copy link
Contributor

Silvyre commented Sep 28, 2019

I'd be willing to give this a go!

@alextarasov1
Copy link
Collaborator Author

Hello @Silvyre,
Thank you for showing interest!
If you decide to make a pull request, I won't be able to review it until I get back from vacation on October 18 2019.

@Silvyre
Copy link
Contributor

Silvyre commented Oct 2, 2019

Hi, Alex. Thank you for letting me know!

Silvyre added a commit to Silvyre/RestfulHttpsProxy that referenced this issue Oct 27, 2019
@Silvyre
pass ports to main.go and dockerfile from makefile (Comcast#5)
6876e7b
Silvyre added a commit to Silvyre/RestfulHttpsProxy that referenced this issue Oct 27, 2019
@Silvyre
pass ports to main.go and dockerfile from makefile (Comcast#5)
0aa82ef
Silvyre added a commit to Silvyre/RestfulHttpsProxy that referenced this issue Oct 27, 2019
@Silvyre
add command line args to dockerfile's callback to makefile (Comcast#5)
80fe7a1
Silvyre added a commit to Silvyre/RestfulHttpsProxy that referenced this issue Oct 27, 2019
@Silvyre
Resolves Comcast#5: adds port selection via command line arguments
47e86b4
@Silvyre Silvyre mentioned this issue Oct 27, 2019
Merged
alextarasov1 added a commit that referenced this issue Oct 28, 2019
@alextarasov1
Merge pull request #11 from Silvyre/issue-5-ports-via-command-line
9ff695a 
Resolves #5: adds port selection via command line arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves #5: adds port selection via command line arguments Silvyre/RestfulHttpsProxy
2 participants
@Silvyre @alextarasov1