psi: handle multi-table PMT split across multiple packets #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a serious bug where the accumulator wouldn't work if the caller was re-using a packet buffer (like in the tests or cli for example).
|
I was able to fix my new test by changing the accumulator to make a copy of the packet before storing it (a6ff222): - a.packets = append(a.packets, pkt)
+ pktCopy := make(Packet, PacketSize)
+ copy(pktCopy, pkt)
+ a.packets = append(a.packets, pktCopy)It's surprising this wasn't caught before.. |
tmm1
changed the title
|
Hope everyone had a great weekend. Would love a review here when you have a moment. |
|
It was a good weekend. reviewing it now. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #75 and #85, which both dealt with cases where multiple tables exist in the PMT stream (SCTE 0xc0 table as well as 0x2 program map table).
This time, the 0xc0 and 0x2 tables are again combined (like with #75), however now the combined size is larger than a single packet so the payload has to be continued into a second packet.
I added a test case, and fixed the PMTDoneFunc implementation, however the new test is still not passing. It looks like I've uncovered some sort of bug in the accumulator. When I observe the the values of the packets in
accumulator.Parse(), both entries have the same contents. Somehow the contents of the first packet are being lost between the first and second invocations of the doneFunc.cc @kortschak since he was looking at the accumulator recently as well