Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Spring app is broken in Jetty container #145

Open
HaloFour opened this issue Oct 14, 2020 · 1 comment
Open

Sample Spring app is broken in Jetty container #145

HaloFour opened this issue Oct 14, 2020 · 1 comment

Comments

@HaloFour
Copy link
Collaborator

The version of Jackson currently used by the Spring sample project has an embedded module-info for Java 9 JMS which causes Jetty to throw an exception when scanning for attributes. We would need to upgrade to at least Jetty 9.4.x which has support for Java 9, even if we're running on a Java 8 runtime. I did attempt that upgrade last night but was having trouble getting the Spring mappings to work so that will require additional work. However, downgrading Jackson back to 2.9.x works around the issue.

See: jetty/jetty.project#1692

@joakime
Copy link

joakime commented Feb 22, 2021

Looking at https://github.com/Comcast/money/blob/master/samples/samples-springmvc/pom.xml#L14

It references Jetty 8.x, which is EOL (End of Life) and should not be used.
Jetty 8.x is also subject to several security issues, be aware of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants