Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OTel Resource via config within SpanExporter adapter #197

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

HaloFour
Copy link
Collaborator

@HaloFour HaloFour commented Aug 4, 2023

Adds support for resource configuration in adapter for OTel SpanExporters. Lightbend Config supports environment variable substitution out of the box:

handling = {
  async = true
  handlers = [
    {
      class = "com.comcast.money.otel.handlers.jaeger.JaegerOtelSpanHandler"
      resource = {
        deployment.environment = ${?XVP_ENV}
        cloud.region = ${?AWS_REGION}
      }
      batch = true
      exporter-timeout-ms = 30000
      max-batch-size = 512
      max-queue-size = 2048
      schedule-delay-ms = 5000
      exporter {
        endpoint = "localhost:14250"
        timeout-ms = 1000
      }
    }
  ]
}

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #197 (6611a00) into master (37e1225) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   93.96%   94.02%   +0.06%     
==========================================
  Files          94       94              
  Lines        1260     1273      +13     
  Branches       68       72       +4     
==========================================
+ Hits         1184     1197      +13     
  Misses         76       76              
Files Changed Coverage Δ
...st/money/otel/handlers/MoneyReadableSpanData.scala 96.77% <100.00%> (+0.22%) ⬆️
.../comcast/money/otel/handlers/OtelSpanHandler.scala 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@HaloFour HaloFour merged commit b9e1862 into master Aug 8, 2023
3 checks passed
@HaloFour HaloFour deleted the jbs/otel-handler-resource-config branch August 8, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants