Consumer/position re-consume unacked or from topic start #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the `InitialPosition` field to be set when creating a new subscriber. More tests should be added around this in the future. For now, it's only available for "exclusive" consumers, but could be added to other subscription types.
* expose options for re-reading unacked messages Signed-off-by: David Walter <davidwalter0@users.noreply.github.com> * fix comment typos Signed-off-by: David Walter <davidwalter0@users.noreply.github.com> * Per review: prefer caller returns result directly Signed-off-by: David Walter <davidwalter0@users.noreply.github.com> * update comment wording
awilliams
reviewed
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose options for re-reading unacked message and add ability to consume from beginning of topic