Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer/position #18

Merged
merged 4 commits into from Jan 25, 2019
Merged

Consumer/position #18

merged 4 commits into from Jan 25, 2019

Conversation

davidwalter0
Copy link
Collaborator

changes related to initial position of cursor and reconsumption of unacked messages

awilliams and others added 4 commits November 30, 2018 15:53
This allows for the `InitialPosition` field to be set when creating a
new subscriber. More tests should be added around this in the future.
For now, it's only available for "exclusive" consumers, but could be
added to other subscription types.
* expose options for re-reading unacked messages

Signed-off-by: David Walter <davidwalter0@users.noreply.github.com>

* fix comment typos

Signed-off-by: David Walter <davidwalter0@users.noreply.github.com>

* Per review: prefer caller returns result directly

Signed-off-by: David Walter <davidwalter0@users.noreply.github.com>

* update comment wording
- pulsar unacknowledged reads initial reads work
- some unacknowledged subsequent reads fail
- some use cases cases invalidate queue connections
- deferrable lock release
@davidwalter0 davidwalter0 merged commit d669484 into master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant