New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StringProvider not generated on it's own #29
Comments
Any updates on the StringProvider generation issue? |
I haven't tested this, I'll try to look into it soon |
dapp
added a commit
that referenced
this issue
Oct 23, 2019
dapp
added a commit
that referenced
this issue
Oct 23, 2019
Issue #29 - Fix string provider generation toggle
Fixed and released in version https://github.com/Comcast/resourceprovider/releases/tag/v1.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Almost got this library working in my project completely.
The only problem I'm still having now is a strange issue where StringProvider is only ever generated if every single other provider is generated (ie not generated if any flags in the application annotation are set to false).
While not ideal, for testing purposes I attempted to just take all providers to see if it worked finally. It was here that I found that any resource names that end in an underscore would cause the build to fail. Normally this would just be a simple refactoring fix, but unfortunately library resources are also taken into account and for some reason Instabug uses some resources with trailing underscores (which I can't do anything about).
I don't know if the underscore issue is fixable but it isn't as important for my use case since I believe it only crashes for me if I generate the DrawableProvider.
Also a small thing I also found while trying to get this library to play nicely with my project. Apparently the Application subclass annotated with RpApplication needs to be in the root of the project for the ResourceProvider to be generated correctly. It might be worth mentioning this in the ReadMe in case anyone else runs into this issue.
Thanks for reading this mini essay.
The text was updated successfully, but these errors were encountered: