use boundaries to normalize drag position and only update up knob pos…

…ition really changes
CometVisu · Oct 29, 2017 · 0584cad · 0584cad
1 parent 6534214
commit 0584cad
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/source/class/cv/ui/website/Slider.js b/source/class/cv/ui/website/Slider.js
@@ -68,6 +68,7 @@ qx.Class.define('cv.ui.website.Slider', {
   */
   members: {
     __pointerMoveEvent: null,
+    __positionKnob: null,
 
     init: function() {
       this.base(arguments);
@@ -109,14 +110,19 @@ qx.Class.define('cv.ui.website.Slider', {
       e.preventDefault();
 
       if (this.__dragMode) {
-        var dragPosition = e.getDocumentLeft();
+        // position normalization
+        var dragBoundaries = this._getDragBoundaries();
+        var dragPosition = Math.max(e.getDocumentLeft(), dragBoundaries.min);
+        dragPosition = Math.min(dragPosition, dragBoundaries.max);
+
         var paddingLeft = Math.ceil(parseFloat(this.getStyle("paddingLeft")) || 0);
         var positionKnob = dragPosition - this.getOffset().left - this._getHalfKnobWidth() - paddingLeft;
 
-        this.setValue(this._getNearestValue(dragPosition));
-        if (positionKnob > 0) {
+        if (this.__positionKnob !== positionKnob) {
+          this.setValue(this._getNearestValue(dragPosition));
           this._setKnobPosition(positionKnob);
           this.emit("changePosition", positionKnob);
+          this.__positionKnob = positionKnob;
         }
         e.stopPropagation();
       }