Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar-left width is not set to 0 when its set to not visible by sub-page #1266

Closed
peuter opened this issue Apr 5, 2022 · 0 comments · Fixed by #1275
Closed

Navbar-left width is not set to 0 when its set to not visible by sub-page #1266

peuter opened this issue Apr 5, 2022 · 0 comments · Fixed by #1275
Assignees
@ChristianMayer
Labels
bug / bugfix core
Projects
Next Release
Milestone
0.12.0

Comments

@peuter
Copy link
Member

peuter commented Apr 5, 2022

error reported here: https://knx-user-forum.de/forum/supportforen/cometvisu/1757782-0-12-0-rc9-image-widget-erscheint-unter-hinter-statusbar-bottom

Reproducible with the attached sample config. When the subpage is opened the left navbar still has a fixed width of 200px and that breaks the layout.
@peuter peuter added this to the 0.12.0 milestone Apr 5, 2022
@peuter peuter added this to To do in Next Release via automation Apr 5, 2022
ChristianMayer added a commit to ChristianMayer/CometVisu that referenced this issue May 1, 2022
@ChristianMayer
Fix navbar on subpages where it is not inherited anymore.
958e3eb 
Closes CometVisu#1266.
ChristianMayer added a commit to ChristianMayer/CometVisu that referenced this issue May 1, 2022
@ChristianMayer
Fix navbar on subpages where it is not inherited anymore.
60e641f 
Closes CometVisu#1266.
@ChristianMayer ChristianMayer mentioned this issue May 1, 2022
Merged
Next Release automation moved this from To do to Done May 2, 2022
ChristianMayer added a commit that referenced this issue May 11, 2022
@ChristianMayer
Fix navbar on subpages where it is not inherited anymore.
b11bbce 
Closes #1266.

(cherry picked from commit 60e641f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristianMayer ChristianMayer

Labels
bug / bugfix core
Projects
No open projects
Next Release
  
Done
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Fix navbar on subpages where it is not inherited anymore. ChristianMayer/CometVisu
2 participants
@peuter @ChristianMayer