Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make startpage parameter more robust #350

Closed
ChristianMayer opened this issue Jun 10, 2016 · 2 comments
Closed

Make startpage parameter more robust #350

ChristianMayer opened this issue Jun 10, 2016 · 2 comments
Assignees
@ChristianMayer
Labels
bug / bugfix
Milestone
0.10.0

Comments

@ChristianMayer
Copy link
Member

When the startpage URL parameter is set but doesn't exists (e.g. due to a typo) the CV doesn't display the page.

Testcase: http://wiregate/cometvisu/?config=demo&startpage=id_51 (instead of the working http://wiregate/cometvisu/?config=demo&startpage=id_51_ )

This also creates a (sporadic?) error in the console:

templateengine.js [sm]:1575 Uncaught TypeError: Cannot read property 'beforePageChange' of undefined
TemplateEngine.scrollToPage @   templateengine.js [sm]:1575
setup_page  @   templateengine.js [sm]:1325
(anonymous function)    @   templateengine.js [sm]:216
execCb  @   require-2.1.15.min.js.src.js:29
@ChristianMayer ChristianMayer added this to the next feature release milestone Jun 10, 2016
@ChristianMayer ChristianMayer self-assigned this Jan 6, 2017
@ChristianMayer ChristianMayer modified the milestones: 0.10.0, next feature release Jan 6, 2017
@ChristianMayer
Copy link
Member Author

This should be fixed for 0.10.0

@ChristianMayer ChristianMayer mentioned this issue Jan 7, 2017
Merged
peuter added a commit that referenced this issue Jan 9, 2017
@peuter
Merge pull request #457 from ChristianMayer/fix_350_Make_startpage_pa…
d0b0adb 
…rameter_more_robust

Fix issue #350: Make startpage parameter more robust
@peuter
Copy link
Member

peuter commented Jan 9, 2017

Closed by #457

@peuter peuter closed this as completed Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristianMayer ChristianMayer

Labels
bug / bugfix
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
2 participants
@peuter @ChristianMayer