Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not show client connection error when the cometvisu is in the back… #1018

Merged

Conversation

peuter
Copy link
Member

@peuter peuter commented May 4, 2020

…ground and reconnect after resume then the connection is lost

This should prevent the error being shown after the cometvisu get re-opened on a smartphone.

This PR also includes a minor compiler improvement that prevents from files beeing synced every time the compiler is re-run in watchmode

…ground and reconnect after resume then the connection is lost

This should prevent the error being shown after the cometvisu get re-opened on a smartphone.

This PR also includes a minor compiler improvement that prevents from files beeing synced every time the compiler is re-run in watchmode
@peuter peuter added this to the 0.12 (post 0.11.0) milestone May 4, 2020
@peuter peuter requested a review from ChristianMayer May 4, 2020 17:27
@peuter peuter added this to To do in Next Release via automation May 4, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 61.927% when pulling 724c3dc on peuter:fix-client-connection-error into 8e2bba7 on CometVisu:develop.

@ChristianMayer ChristianMayer merged commit ea7ad8a into CometVisu:develop May 10, 2020
Next Release automation moved this from To do to Done May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Next Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants