Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not process influx data by backend processors, because it is alrea… #1313

Merged
merged 3 commits into from Jan 15, 2023

Conversation

peuter
Copy link
Member

@peuter peuter commented Jan 15, 2023

…dy in the right format. Fix openHAB backend client data processing.

closes #1312

…dy in the right format. Fix openHAB backend client data processing.

closes CometVisu#1312
@peuter peuter added bug / bugfix needs-to-be-cherry-picked This PR needs to be cherry picked to the lateste release branch after it hast been merged labels Jan 15, 2023
@peuter peuter marked this pull request as draft January 15, 2023 16:17
peuter

This comment was marked as off-topic.

@peuter peuter marked this pull request as ready for review January 15, 2023 16:53
@ChristianMayer
Copy link
Member

This should be a pull request against develop and not master

@peuter
Copy link
Member Author

peuter commented Jan 15, 2023

This should be a pull request against develop and not master

No this is a bugfix for the 0.12.x release, which is developed and released in the master branch. It also needs to be done for the develop branch, but that is not ready yet. I still have to check if a simple cherry-pick is possbile or if it needs more changes as the backend implementation is different in the develop branch (due to the multi-backend support).

@ChristianMayer
Copy link
Member

But I thought we had the release-0.12 branch for that?

@peuter
Copy link
Member Author

peuter commented Jan 15, 2023

Please read my last comment in gitter where I explained that. The "latest" release needs to be build from the master-branch, otherwise things do not work right (e.g. docker tagging). The whole CI process is build for the following setup:

  • master-branch: latest release
  • develop-branch: testing releases (aka nighty builds)
  • release-x.x branches: legacy releases

@ChristianMayer
Copy link
Member

We should continue that discussion on Gitter. As it must end up in master anyway I'll pull it to save some time

@ChristianMayer ChristianMayer merged commit 262fc26 into CometVisu:master Jan 15, 2023
@peuter peuter added was-cherry-picked DONE: This PR needed to be cherry picked to the lateste release branch after it hast been merged and removed needs-to-be-cherry-picked This PR needs to be cherry picked to the lateste release branch after it hast been merged labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / bugfix was-cherry-picked DONE: This PR needed to be cherry picked to the lateste release branch after it hast been merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants