New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multi-backend support to pure structure and recording #1345
add multi-backend support to pure structure and recording #1345
Conversation
also fix replaying xhr responses that are delayed
getType return value of the default client
Should work now |
The read request should work now, the GET-Request to cgi-bin/ is not reproducable for me. |
Do you have a openhab backend url configured somewhere? What are the cometvisu specific headers that are send with the config response? Is there a X-CometVisu-Backend-OpenHAB-Url and/or X-CometVisu-Backend-Name set? |
Looking at https://github.com/CometVisu/Docker/blob/master/CometVisuBase/cometvisu-entrypoint#L40-L64 I think this is (currently) an expected behavior |
Yes I just checked that too, I think we should delete this line https://github.com/CometVisu/Docker/blob/master/CometVisuBase/cometvisu-entrypoint#L40 I will also change this pull request to handle the backend names as comma separated list correctly, I wasn't aware that this is allowed. Then I will only create clients for the backends that are in that list. That should fix your problem too. |
Is is safe (backward compatible) to delete this line 40? |
I don't remember if we ever had a release where you had to use the CGI-URL variable to configure the path to the openhab backend. But its clearly wrong if someone did that, so I would take the risk to find someone who has this kind of configuration and make him fix it by removing this behavior. |
btw as CGI_URL_PATH is deprecated you should remove it from your configuration. |
I know, it's in there due to laziness and testing what's happening to a user who didn't remove it :) |
also fix replaying xhr responses that are delayed