Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix counter image #464

Merged
merged 1 commit into from Jan 15, 2017
Merged

Fix counter image #464

merged 1 commit into from Jan 15, 2017

Conversation

ChristianMayer
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.012% when pulling 8fc6ef7 on ChristianMayer:fix_demo_config into 9492a53 on CometVisu:develop.

@peuter peuter merged commit ad66764 into CometVisu:develop Jan 15, 2017
@peuter
Copy link
Member

peuter commented Jan 15, 2017

Sorry guess I did something wrong, while testing this PR. After pulling to the last develop-Version the navbar in the Demo-Config looks kind of broken. Like the Pagejumps are floating when they should not. Could you check if this is wanted
bildschirmfoto vom 2017-01-15 09-45-52

@ChristianMayer
Copy link
Member Author

@peuter Please try with enableCache=invalid (like http://wiregate/visu_git/?config=demo&forceReload=true&enableCache=invalid ) - that solved it for me

I think we need to have a closed look at the Cache logic before the release...

@ChristianMayer ChristianMayer mentioned this pull request Jan 15, 2017
Closed
@ChristianMayer ChristianMayer deleted the fix_demo_config branch January 15, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristianMayer @coveralls @peuter