Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messagecenter enhancements #613

Merged
merged 17 commits into from Sep 17, 2017
Merged

Conversation

peuter
Copy link
Member

@peuter peuter commented Sep 12, 2017

  • add source-build target to test global error handling in source version
  • add documentation for notifications (incl. screenshots)
  • new message target: speech for TTS messages
  • improve schema annotation retrieval for attribute enumeration annotations

refs #602

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 56.185% when pulling 0b21687 on peuter:messagecenter into 68262f5 on CometVisu:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 57.901% when pulling c49c472 on peuter:messagecenter into 68262f5 on CometVisu:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.8%) to 59.827% when pulling cd258f9 on peuter:messagecenter into 68262f5 on CometVisu:develop.

@@ -106,8 +114,44 @@ Um den etwas kryptischen Adressennamen in ein lesbares Format zu bringen wird ei
Wenn der Bewegungsmelder mit dem Namen *Motion_FF_Corridor* nun eine Bewegung signalisiert würde die Nachricht
folgenden Inhalt haben:

.. code-block:: text
.. figure:: _static/nachrichten_zentrale.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to generate that screenshot automatically as we do with the other ones?
(This would help with translation as well as with future versions with possible design changes)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole screenshot tool is customized for widgets. So this is currently not possible and would be a bigger change. We should keep that in mind. But its definitely not an option for his PR.

solange das Problem besteht und verschwinden automatisch, sobald das Problem behoben wurde.


.. figure:: _static/noticenter_hidden.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above


Geschlossene Nachrichtenzentrale mit einer kritischen Fehlermeldung

.. figure:: _static/NotificationCenter.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

case "speech":
if (!window.speechSynthesis) {
// not supported
qx.log.Logger.warn(this, "this browser does not support the Web Speech API");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be handled more gracefully, e.g. with an option to ignore such a warning as it seems that older but well used Android doesn't support it yet: http://caniuse.com/#feat=speech-synthesis

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those logs messages are only written to the browser console, yo you wouldn't see it in a mobile device anyways. Its just meant as a hint for the user to explain why the speech target is not working (if the user opens the javascript console to look for possible errors). This is not something that would be visible in the CometVisu itself. So I think it is ok like it is.

@@ -68,7 +69,8 @@ qx.Class.define("cv.core.notifications.SpeechHandler", {
}
},

say: function(text, language) {
say: /* istanbul ignore next [no need to text the browsers TTS capability] */ function(text, language) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • istanbul?
  • "text" or "test"?

@ChristianMayer ChristianMayer merged commit 8dc9b70 into CometVisu:develop Sep 17, 2017
@peuter peuter deleted the messagecenter branch October 28, 2017 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants