New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messagecenter enhancements #613
Conversation
…e global error handling
…e global error handling
@@ -106,8 +114,44 @@ Um den etwas kryptischen Adressennamen in ein lesbares Format zu bringen wird ei | |||
Wenn der Bewegungsmelder mit dem Namen *Motion_FF_Corridor* nun eine Bewegung signalisiert würde die Nachricht | |||
folgenden Inhalt haben: | |||
|
|||
.. code-block:: text | |||
.. figure:: _static/nachrichten_zentrale.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to generate that screenshot automatically as we do with the other ones?
(This would help with translation as well as with future versions with possible design changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole screenshot tool is customized for widgets. So this is currently not possible and would be a bigger change. We should keep that in mind. But its definitely not an option for his PR.
solange das Problem besteht und verschwinden automatisch, sobald das Problem behoben wurde. | ||
|
||
|
||
.. figure:: _static/noticenter_hidden.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
|
||
Geschlossene Nachrichtenzentrale mit einer kritischen Fehlermeldung | ||
|
||
.. figure:: _static/NotificationCenter.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
case "speech": | ||
if (!window.speechSynthesis) { | ||
// not supported | ||
qx.log.Logger.warn(this, "this browser does not support the Web Speech API"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be handled more gracefully, e.g. with an option to ignore such a warning as it seems that older but well used Android doesn't support it yet: http://caniuse.com/#feat=speech-synthesis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those logs messages are only written to the browser console, yo you wouldn't see it in a mobile device anyways. Its just meant as a hint for the user to explain why the speech target is not working (if the user opens the javascript console to look for possible errors). This is not something that would be visible in the CometVisu itself. So I think it is ok like it is.
@@ -68,7 +69,8 @@ qx.Class.define("cv.core.notifications.SpeechHandler", { | |||
} | |||
}, | |||
|
|||
say: function(text, language) { | |||
say: /* istanbul ignore next [no need to text the browsers TTS capability] */ function(text, language) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- istanbul?
- "text" or "test"?
refs #602