Reduce some Qx and switch to native #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advertisement to get rid of it.
Helps the user to identify the issue when the server doesn't want to connect the SOAP due to missing certificates when the correct config option wasn't set.
ChristianMayer
changed the title
peuter
requested changes
Sep 23, 2019
skeletons/widget-test.js
Outdated
| @@ -6,7 +6,7 @@ describe("testing a %WIDGET_NAME% widget", function() { | |||
|
|
|||
| it("should test the %WIDGET_NAME% creator", function() { | |||
| var res = this.createTestWidgetString("%WIDGET_NAME%", {}, "<label>Test</label>"); | |||
| var widget = qx.bom.Html.clean([res[1]])[0]; | |||
| var widget = (function(){var div=document.createElement('div');div.innerHTML=res[1];return div.childNodes[0];})(); | |||
There was a problem hiding this comment.
As it is not really clear what this function does, it should be declared somewhere outside the tests with a self explaining name and a little description. That function can be used everywhere, where qx.bom.Html.cleangot replaced.
…ialized correctly fixes error reported here: https://knx-user-forum.de/forum/supportforen/cometvisu/1416309-speech-plugin-will-nicht
…into reduce_qx
peuter
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #772
This patch reduces the vendor lock in to Qx in about 1000 instances where native JavaScript does the job exactly as well as the Qx layer on top of it.
So this patch means that for each of those actions less code is being run (should give a minimal speed advantage), the code is (at least uncompressed) smaller by about 3.6kb and - most importantly - helps us to stay as independent from any unnecessary code as possible.
There are still many places that would benefit from such a clean up, but it must start somewhere.