Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix initialization of speech plugin in cached mode and wait for voice… #966

Merged
merged 2 commits into from
Nov 3, 2019
Merged

fix initialization of speech plugin in cached mode and wait for voice… #966

merged 2 commits into from
Nov 3, 2019

Conversation

peuter
Copy link
Member

@peuter peuter commented Nov 2, 2019

@peuter peuter added this to the 0.11.3 milestone Nov 2, 2019
@peuter peuter added this to To do in Next Release via automation Nov 2, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 59.083% when pulling 8b7c300 on peuter:fix-speech-cache into 6c3d4cd on CometVisu:release-0.11.

ChristianMayer
ChristianMayer requested changes Nov 2, 2019
View reviewed changes
Copy link
Member

@ChristianMayer ChristianMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch is fine except the format that would also violate semistrict

source/class/cv/core/notifications/SpeechHandler.js Outdated Show resolved Hide resolved
source/class/cv/core/notifications/SpeechHandler.js Outdated Show resolved Hide resolved
@ChristianMayer ChristianMayer merged commit fcdccf8 into CometVisu:release-0.11 Nov 3, 2019
Next Release automation moved this from To do to Done Nov 3, 2019
ChristianMayer referenced this pull request Nov 3, 2019
@peuter @ChristianMayer
fix initialization of speech plugin in cached mode and wait for voice…
5f1ffe2 
…s to be available
ChristianMayer referenced this pull request Nov 3, 2019
@peuter @ChristianMayer
add missing ;
a730eee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMayer ChristianMayer ChristianMayer approved these changes

Assignees
No one assigned
Labels
bug / bugfix plugins
Projects
No open projects
Next Release
  
Done
Milestone
0.11.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peuter @coveralls @ChristianMayer