Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dist folder #15

Closed
wants to merge 2 commits into from

Conversation

TheKnarf
Copy link
Contributor

@TheKnarf TheKnarf commented Mar 8, 2024

  • Remove dist/ folder, this shouldn't be committed
  • Add dist/ folder to .gitignore

@thecooltechguy
Copy link
Contributor

hi @TheKnarf , atm the launcher is comprised of a Python Flask server that serves a React front-end app.

Because we don't want users to need npm/node to build the React app on their end, we currently keep the built js/html/css files in the repo, so that all the user needs to do is start the Flask server and they'll be able to instantly access the React web app.

Storing dist/ in the repo is not ideal, but in this case, it helps simplify the setup & usage for the end user, so if we were to just remove it rn, the app would not install properly for users.

Hmm, is there perhaps another way to achieve this same goal, without needing to add/track the dist/ folder in the repo and requiring the user to have npm/node on their end?

@thecooltechguy thecooltechguy mentioned this pull request Mar 8, 2024
@TheKnarf
Copy link
Contributor Author

TheKnarf commented Mar 8, 2024

Couldn't you just require node and run npm build inside of run.sh? This seems like a really weird way of solving it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants