New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebars #18
Comments
Steps:
|
Some additional work:
The first three should be easy. The fourth might be harder. I'm okay shipping sidebars before we finish the fourth, and then following up on it afterwards. |
We should also make sure to think about how thread search works with sidebars |
I looked into how thread search deals with sidebars right now:
I think we'll eventually need to rework the search results view, but I opened a new issue for that: #122. For now, let's make sure that we:
|
Some more stuff:
|
Things that need to be done:
All of this needs to be done for web also |
EDIT This was done today!! Had so many diffs to review that I missed it initially. A great problem to have :) |
One thought I had just now: right now we're passing the |
Things that need to be done:
|
I realized another thing we'll need to change this morning. We want to display number of replies in the sidebar inline under the message that started the sidebar in the parent thread. But currently, only members of the sidebar have the information to determine the number of messages in that sidebar. I think the best solution is probably to make sure messages get delivered to members of the parent that aren’t members of the sidebar. |
|
Some more stuff:
|
We'll also need to think about |
Two questions popped up last week, one about how we reference the I'm going to summarize where we landed on this stuff here. Some explanation of terminology before I get into it:
Now let me get into the two questions from last week:
|
Separate note: At this point this GitHub issue is getting very long and it's hard to track the remaining work. Unfortunately I simply don't have time to handle the tracking work. @palys-swm – I'm hoping you can take over for me. As a starting point it would be helpful if you could break down the remaining work we have left to get sidebars shipped. |
The list with all the things that are required for the release:
Web:
Things that can be implemented later:
|
Sidebars are a kind of child thread. They're meant for short back-and-forth conversations that start in a longer thread, but don't need to include everybody on that parent thread. In that sense they're somewhat similar to Slack threads.
You can create one by pressing on any message in a chat thread. People in the parent thread won't get notifs about messages in the child thread unless they press through to the child thread and choose to join it.
One crucial difference between the existing kind of child threads and sidebars is how they appear in the thread list. Whereas child threads are their own top-level entity, sidebars appear grouped below their parent thread. You only see the sidebars in which you are a member. If a new message occurs in a sidebar that you are a member, it bumps the whole parent thread to the top of the thread list.
For this reason, whereas standard child threads can have their own child threads, sidebars can not.
If the discussion in a sidebar drags on, and it starts to look like a long-term conversation, it's possible for any user to "upgrade" the sidebar to a standard child thread. If a sidebar gets upgraded, it will retain its link to the message in the parent thread that started it, but will otherwise behave like a standard child thread, appearing as its own entity in the thread list.
The text was updated successfully, but these errors were encountered: