Update "testing" build script so it works regardless of execution location #929
Conversation
Revert "Cail"
Update from upstream repo commandpost/commandpost
Update from upstream repo commandpost/commandpost@develop
Update from upstream repo commandpost/commandpost@develop
Update from upstream repo commandpost/commandpost@develop
Update from upstream repo commandpost/commandpost@develop
Update from upstream repo commandpost/commandpost@develop
Update from upstream repo commandpost/commandpost@develop
Update from upstream repo commandpost/commandpost@develop
Update from upstream repo commandpost/commandpost@develop
Update from upstream repo commandpost/commandpost@develop
Update from upstream repo commandpost/commandpost@develop
| make release | ||
| make docs | ||
| # Import our function library | ||
| # shellcheck source=scripts/inc/librelease.sh disable=SC1091 |
There was a problem hiding this comment.
Couldn't parse this shellcheck annotation.
Expected "disable". Fix any mentioned problems and try again.
There was a problem hiding this comment.
Stickler needs to update their shellcheck version to one that includes the source argument for directives. All this does is tell shellcheck where the script actually is.
| make release | ||
| make docs | ||
| # Import our function library | ||
| # shellcheck source=scripts/inc/librelease.sh disable=SC1091 |
There was a problem hiding this comment.
Couldn't parse this shellcheck annotation.
Expected "disable". Fix any mentioned problems and try again.
There was a problem hiding this comment.
Same comment as above.
There was a problem hiding this comment.
Opened markstory/lint-review#172
Update from upstream repo commandpost/commandpost@develop
Merging latest dev commits
| make release | ||
| make docs | ||
| # Import our function library | ||
| # shellcheck source=scripts/inc/librelease.sh disable=SC1091 |
There was a problem hiding this comment.
Couldn't parse this shellcheck annotation.
Expected "disable". Fix any mentioned problems and try again.
|
It doesn't look like there's anything in your script to change over to the "test" configuration? |
|
The original one was executing |
|
*debug |
|
@latenitefilms are you saying you'd prefer the script to actually build CommandPost-App from the Debug scheme? Thats an easy fix. |
scripts/inc/librelease.sh
Outdated
| @@ -232,6 +232,20 @@ function build_hammerspoon_app() { | |||
| fi | |||
| } | |||
|
|
|||
| function build_hammerspoon_dev() { | |||
| echo "Building CommandPost.app for development..." | |||
| pushd "${HAMMERSPOON_HOME}" >/dev/null | |||
There was a problem hiding this comment.
Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
scripts/inc/librelease.sh
Outdated
| rm build/docs.json | ||
| # make docs | ||
| # make build/html/LuaSkin | ||
| popd >/dev/null |
There was a problem hiding this comment.
Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
|
@latenitefilms this now passes stickler. Let me know if you want the xcodebuild to run against the debug scheme instead. |
|
@cailyoung - To be honest, I'm not really sure how the debug/test scheme works. Need to do some playing around with Hammerspoon. |
I updated
build-commandpost-testing.shso that it:librelease.shto drive the build process so it can be altered later if necessary