Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container listings from filesystem do not include symlinks #1015

Closed
RubenVerborgh opened this issue Oct 20, 2021 · 0 comments · Fixed by #1018
Closed

Container listings from filesystem do not include symlinks #1015

RubenVerborgh opened this issue Oct 20, 2021 · 0 comments · Fixed by #1018
Assignees
Labels
🐛 bug Something isn't working

Comments

@RubenVerborgh
Copy link
Member

When starting a server from the filesystem, symlinks are accessible as (dereferenced) resources through GET, but they do not show up in a container listing.

For example, if I start the server on a folder with contents

  • bar
  • foo symlinked to bar

then both /bar and /foo will work, but / will only list bar.

This is likely due to https://github.com/solid/community-server/blob/93b71eb72688cc501a9435325699eea55b93974c/src/storage/accessors/FileDataAccessor.ts#L279 only accepting files or folders. However, getData will gladly accept them.

I think the behavior should at least be consistent: either we expose them and list them, or we do not expose them.
My preference is exposing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant