-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace redis library with ioredis #1240
chore: replace redis library with ioredis #1240
Conversation
@@ -1,6 +1,6 @@ | |||
import { assert } from 'console'; | |||
import type { RedisClient } from 'redis'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joachimvh I think we should ignore the warning below; up to you whether locally or globally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I was planning to look into this to see if we need to change the linter settings or the import later. Was actually surprised our linter could throw warnings so also going to change that so it's always errors.
@BelgianNoise was having a look and noticed IORedis released v5.x 2 days ago. Would it be interesting to go for that version then? |
I checked out the change logs and there dont seem to be any major changes, bug fixes and stability improvements mainly. I ill bump the version tomorrow. |
@joachimvh, I tried updateing |
Let's stay with this version then for now. I'll look into the linter warning. |
📁 Related issues
/
✍️ Description
The redis resource locker currently does not support redis clusters. The current
redis
library used is too "dumb" to handle clusters appropriatly (extra info on this page).ioredis
has built in cluster support whileredis
does not.