Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add pod seeding integration test #1262

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

joachimvh
Copy link
Member

✍️ Description

We didn't have an integration test for this yet. Lowers the chances of accidentally breaking this feature in the future.

Comment on lines 36 to 37
It is impossible to use this feature to register pods with pre-existing WebIDs,
since the server can not verify ownership this way.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is impossible to use this feature to register pods with pre-existing WebIDs,
since the server can not verify ownership this way.
This feature cannot be used to register pods with pre-existing WebIDs,
which requires an interactive validation step.

@joachimvh joachimvh merged commit db906ae into versions/4.0.0 Apr 14, 2022
@joachimvh joachimvh deleted the test/seed-pods branch April 14, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants