Feat: Have RegexRouterRule take ordered array #1317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📁 Related issues
#302
#947
✍️ Description
This PR changes the Regex to ResourceStore mapping from a Map datastructure to an Array datastructure. The idea is that regexes are now tested in a fallthrough order.
This allows for more predictable routing and even allows for a catchall
/.*/
regex at the end as suggested in #947. This change will however not introduce any catching/default behaviour, it will only setup the datastructure to allow this in the future. Any such change would be better introduced as a fix for #947 itself.The first two comments, calledfix: Revert: ...
, are from the parentfix/#298
branch, once merged, these will be removed after a rebase. So only the latest commit should be reviewed here.✅ PR check list
Before this pull request can be merged, a core maintainer will check whether