Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat [semver.minor]: allow css configuration from package.json or config file #1509

Merged
merged 1 commit into from Nov 24, 2022
Merged

feat [semver.minor]: allow css configuration from package.json or config file #1509

merged 1 commit into from Nov 24, 2022

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Nov 23, 2022 •
edited

📁 Related issues

✍️ Description

Supercedes #1499 targeting main

✅ PR check list

Before this pull request can be merged, a core maintainer will check whether

  • this PR is labeled with the correct semver label
    • semver.patch: Backwards compatible bug fixes.
    • semver.minor: Backwards compatible feature additions.
    • semver.major: Breaking changes. This includes changing interfaces or configuration behaviour.
  • the correct branch is targeted. Patch updates can target main, other changes should target the latest versions/* branch.
  • the RELEASE_NOTES.md document in case of relevant feature or config changes.
  • any relevant documentation was updated to reflect the changes in this PR.

@jeswr jeswr changed the title feat: allow css configuration from package.json or config file feat [semver.minor]: allow css configuration from package.json or config file Nov 23, 2022
@jeswr
Copy link
Contributor Author

jeswr commented Nov 24, 2022

This is ready for review @joachimvh

joachimvh
joachimvh approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@joachimvh joachimvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx.

@joachimvh joachimvh merged commit d61bf9b into CommunitySolidServer:main Nov 24, 2022
@joachimvh joachimvh mentioned this pull request Nov 24, 2022
Closed
@jeswr jeswr deleted the feat/init-from-package-json-main branch November 24, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachimvh joachimvh joachimvh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeswr @joachimvh