fix: Enable strict TypeScript settings #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets TypeScript to strict
Biggest changes:
webId
field inCredentials
optional. This way theCredentialsExtractor
always returns aCredentials
object, even if no credentials were found. (Instead of returning undefined in that case).BodyParser
now returnsRepresentation | undefined
. Not convinced that this is the best solution, but it is what is needed for now since theSimpleBodyParser
also handles the case of there being no body. Perhaps this should be caught in theRequestParser
instead. Related to Handle HttpRequests with no body #8 .canHandle
function was needed again in thehandle
function to prevent accessing potentialundefined
data since some input fields are optional. E.g. the method field in aHttpRequest
. Another option would be to leave behind that duplicate check and tell TypeScript to trust us that the data is there (since it should have been checked incanHandle
). Not that big of an issue but might become a problem in the future if more advanced checks are needed.!
operator was used in some cases to convince TypeScript that it shouldn't worry. Specifically in these cases:Object.assign
was used to assign values to the class variables. The only way to get around that would be to assign them all manually which can get ugly if there are many. Related TypeScript issue with people complaining about this here (so far it has not been fixed).