Added multitarget support for the Windows App SDK #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arlodotexe
commented
Dec 16, 2021
CommunityToolkit.Labs.WinAppSdk/CommunityToolkit - Backup.Labs.WinAppSdk.csproj
Outdated
Show resolved
Hide resolved
Labs/CanvasLayout/samples/CanvasLayout.WinAppSdk/Package.appxmanifest
Outdated
Show resolved
Hide resolved
Labs/CanvasLayout/samples/CanvasLayout.WinAppSdk/Package.appxmanifest
Outdated
Show resolved
Hide resolved
XAML-Knight
approved these changes
Jan 11, 2022
Arlodotexe
commented
Jan 13, 2022
michael-hawker
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Couple of small things but looks good. To clarify, with this setup, our library packages in Labs, we build with out of the box support for:
- UWP
- WinUI 3/WinAppSDK
- Uno/WASM w/ UWP
But not the Uno for WinUI3? (TBH, I'm still a bit fuzzy on how Uno splits between UWP and WinUI 3)
|
Oh, also the generated files aren't part of the |
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
…nappsdk Added multitarget support for the Windows App SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added multitarget support for the Windows App SDK. Closes #14
This PR:
CommunityToolkit.Labs.WinAppSdk- for the multi-sample app.CanvasLayout.WinAppSdk- for the single-sample app.Labs.UnoLib.props- Is nowLabs.MultiTarget.propsand adds WinAppSDK alongside UWP and Uno.net6.0-windows10.0.19041.0- as a TargetFramework for libraries and projects.WINAPPSDK- as a compilation conditional.Before testing, you MUST do a full clean. Visual Studio may fail to find some assemblies otherwise, and you'll get a "No sample pages were found :(" message.