-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more example test cases to Project Template #189
Conversation
beb8cc9
to
cd146ab
Compare
Hmm, something's odd with XAML Styler, I ran the command before commit but it didn't fix anything. Will have to investigate later. It's also asking for 'input objects' now, which I'm not sure why. |
I have the same issue! Normally I was able to just run it, now it asks for input. |
cd146ab
to
86f2997
Compare
Was able to piecemeal running the tests locally but not smoothly due to #188. But the examples are complete and seem to be running ok. So, if the CI runs, we should be good. Still confused as to why this is happening. |
…s and patterns. Blocked testing locally by #188
86f2997
to
c455bef
Compare
template/lab/tests/ProjectTemplate.Tests/ExampleProjectTemplateTestClass.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except for one small detail.
template/lab/tests/ProjectTemplate.Tests/ExampleProjectTemplateTestClass.cs
Show resolved
Hide resolved
Discovered an issue with the
Looked into the generator and seems like it's missing methods that aren't using the control parameter now, was able to add a generic expect generation guard to the test suite to check this: Will add this to the other SG tests (to ensure we haven't missed anything else), and then see if I can resolve the underlying issue and finish with these tests updates. In the meantime @Arlodotexe let me know if the other test that I was trying to add appears to be inline with what you were thinking around your comment. |
I may also be using the roslyn method wrong still, will dig in more after lunch and try and learn more. |
…shore up tests to check for specific outputs Fixes issue with LabsUITestMethod not generating test for tests not using a control parameter.
828fb93
to
753beec
Compare
...on/CommunityToolkit.Labs.Core.SourceGenerators.LabsUITestMethod/LabsUITestMethodGenerator.cs
Show resolved
Hide resolved
template/lab/tests/ProjectTemplate.Tests/ExampleProjectTemplateTestClass.cs
Outdated
Show resolved
Hide resolved
template/lab/tests/ProjectTemplate.Tests/ExampleProjectTemplateTestClass.cs
Outdated
Show resolved
Hide resolved
|
…using warning/error in CI for generated code.
…ojectTemplate example tests.
Fixes #160 - Add a suite of example test cases for different scenarios and patterns.
Blocked testing locally by #188, figured could see at least if they work in the CI as I think they're all good to go basically anyway... we'l see, will leave it as draft for now until #188 is resolved.