[Experiment] TitleBar #459

niels9001 · 2023-07-04T19:05:40Z

Addressing: #454

ghost1372 · 2023-07-04T19:24:22Z

ContextMenu theme is wrong and always light (i can fix this issue, can i make a pr for this?)

this code can fix this issues:

public static void SetPreferredAppMode(ElementTheme theme)
    {
        if (theme == ElementTheme.Dark)
        {
            NativeMethods.SetPreferredAppMode(NativeMethods.PreferredAppMode.ForceDark);
        }
        else if (theme == ElementTheme.Light)
        {
            NativeMethods.SetPreferredAppMode(NativeMethods.PreferredAppMode.ForceLight);
        }
        else
        {
            NativeMethods.SetPreferredAppMode(NativeMethods.PreferredAppMode.Default);
        }
        NativeMethods.FlushMenuThemes();
    }

ghost1372 · 2023-07-04T19:45:36Z

@niels9001
For some of the problems I reported, I can create a PR. Is that possible?

niels9001 · 2023-07-04T19:49:12Z

Tnx @niels9001

Some Issues:

TitleBar Buttons Should be updated based on windows theme in Active/DeActive State: (i can fix this issue, can i make a pr for this?)

Sure, go ahead - feel free to PR against this branch!

ContextMenu theme is wrong and always light (i can fix this issue, can i make a pr for this?)

I believe WASDK 1.4 should I address this issue.. let me sync with that team to see if that's correct and we don't need to do any registry stuff?

dongle-the-gadget · 2023-07-06T09:52:57Z

ContextMenu theme is wrong and always light (i can fix this issue, can i make a pr for this?)

IIRC it requires a private API to be used extremely early into the loading process.

Remove GetAppWindow() and Use Window.AppWindow

…tons

UpdateCaptionButtons

…mmunityToolkit/Labs-Windows into niels9001/titlebar-experiment

Jay-o-Way · 2023-07-11T14:51:06Z

in TitleBar Height = Standard , we can not use VerticalAlignment="Center" for AutoSuggestBox or other controls

That's the reason "tall" should be used as soon as there are interactive/input controls. Don't know if it's possible to force this setting, in the logic, based on content?

Jay-o-Way · 2023-07-11T15:12:15Z

@ghost1372 you might want to re-count those pixels

ghost1372 · 2023-07-11T15:26:15Z

you might want to re-count those pixels

I don't want the size of the buttons to be big, just like the store, I want it to be small, but the autosuggestbox stays in the center!

Jay-o-Way

Hope we can use this in PowerToys soon 🙂

components/TitleBar/samples/TitleBar.md

Jay-o-Way · 2023-07-11T15:40:07Z

@ghost1372 oh sorry, now i see those buttons. @niels9001 those should stay untouched.

niels9001 · 2023-07-11T15:43:31Z

@Jay-o-Way Please leave any generic questions/comments in the discussion and not in this PR.

niels9001 · 2023-07-11T15:48:38Z

in TitleBar Height = Standard , we can not use VerticalAlignment="Center" for AutoSuggestBox or other controls

That's the reason "tall" should be used as soon as there are interactive/input controls. Don't know if it's possible to force this setting, in the logic, based on content?

Microsoft itself has used the standard mode, so we definitely do not need the tall mode to implement this mode, Store is a perfect example

@niels9001 When will you merge this PR? It's been almost 2 weeks...

I have some other stuff that got prioritized. I think in terms of features, we are in a good spot with this PR - or do you see any must-have things that need to be fixed still? I think having some basic tests in place would be good to have - if that's something you want to help out with let me know!

michael-hawker · 2023-07-11T16:24:33Z

components/TitleBar/src/TitleBar.WASDK.cs

+    [DllImport("Shcore.dll", SetLastError = true)]
+    internal static extern int GetDpiForMonitor(IntPtr hmonitor, Monitor_DPI_Type dpiType, out uint dpiX, out uint dpiY);


Seems silly for a single method, but can use CsWin32 to generate these instead...

Jay-o-Way · 2023-12-27T17:27:54Z

Although, I don't have any image in mind of integrating the titlebar with the tabview.
Is there an example?

Pretty much any tabbed window. Notepad, Explorer, browsers...

ghost1372 · 2023-12-27T17:31:17Z

Thank you @Jay-o-Way @AnalogFeelings
I would like to work on it😁

ghost1372 · 2024-01-03T13:32:05Z

Hi @pratikone
Can you help us?
which one we should use?

Window.ExtendsContentIntoTitleBar + Window.SetTitleBar()
or
Window.AppWindow.TitleBar.ExtendsContentIntoTitleBar

pratikone · 2024-01-03T14:32:01Z

Hi @pratikone
Can you help us?
which one we should use?

Window.ExtendsContentIntoTitleBar + Window.SetTitleBar()
or
Window.AppWindow.TitleBar.ExtendsContentIntoTitleBar

Both are correct answers because both use same code underneath. The former is for ease of use, latter is more low level and provides finer control . So if you are creating custom drag regions, latter is good too. You can also mix and match APIs. Like setup titlebar using Window APIs and modify drag regions using appwindow APIs.

First see if default titlebar is good enough. I've changed default titlebar with winappsdk 1.4 release to represent the most common case : full width custom titlebar

insomniachi · 2024-01-09T12:00:54Z

Is there anything i need to do while hiding the titlebar ?
i referred this from msdocs to hide the title bar

public MainWindow()
{
    this.InitializeComponent();

    m_AppWindow = this.AppWindow;
    m_AppWindow.Changed += AppWindow_Changed;
}

private void AppWindow_Changed(AppWindow sender, AppWindowChangedEventArgs args)
{
    if (args.DidPresenterChange)
    {
        switch (sender.Presenter.Kind)
        {
            case AppWindowPresenterKind.CompactOverlay:
                // Compact overlay - hide custom title bar
                // and use the default system title bar instead.
                AppTitleBar.Visibility = Visibility.Collapsed;
                sender.TitleBar.ResetToDefault();
                break;

            case AppWindowPresenterKind.FullScreen:
                // Full screen - hide the custom title bar
                // and the default system title bar.
                AppTitleBar.Visibility = Visibility.Collapsed;
                sender.TitleBar.ExtendsContentIntoTitleBar = true;
                break;

            case AppWindowPresenterKind.Overlapped:
                // Normal - hide the system title bar
                // and use the custom title bar instead.
                AppTitleBar.Visibility = Visibility.Visible;
                sender.TitleBar.ExtendsContentIntoTitleBar = true;
                break;

            default:
                // Use the default system title bar.
                sender.TitleBar.ResetToDefault();
                break;
        }
    }
}

because my application is crashing while returning from fullscreen mode to Overlappedmode. (this is not always, but it randomly happens. i'm not able to identify why or when it happens.)
but i'm sure it's something wrong with the titlebar because when i don't use it, App never crashes.

ghost1372 · 2024-01-09T12:30:16Z

Hi @insomniachi
I did not test hiding labs titlebar, but if you call ResetToDefault, titlebar will be reseted to default so custom titlebar will be gone. If you want to hide titlebar, i think using visibility property is standard way.
Also if you want to use ResetToDefault, you can set AutoConfigureCustomTitleBar = "false"

insomniachi · 2024-01-09T12:32:12Z

in my case, it'll never call reset to default because I'm only switching between Overlapped/Fullscreen, in that I'm only changing visibility

ghost1372 · 2024-01-09T12:36:16Z

in my case, it'll never call reset to default because I'm only switching between Overlapped/Fullscreen, in that I'm only changing visibility

So you should set AutoConfigureCustomTitleBar = false when you are switching between Overlapped/Fullscreen

If you can please upload a sample so i can test it better.

insomniachi · 2024-01-09T15:09:36Z

reproduceable sample
https://github.com/insomniachi/CTK_TitleBar_Crash (default template from Template Studio)
it will not crash when running from visual studio.

publish unpackaged win-x64 in release mode
run exe
there should be a media player element in the main page
play video
double click the media player element to go to Fullscreen.
while playing double click again to come back to overlapped. it should crash, or repeat the Fullscreen and back steps a few times, it should eventually crash.

ghost1372 · 2024-01-09T19:01:32Z

Tnx @insomniachi
i tested 100 times but i did not see any crash, mybe something related to MediaPlayerElement or WinUI Windowing iteself, so i suggest you report issue in Microsoft.UI.Xaml or WindowsAppSDK repo

insomniachi · 2024-01-10T04:20:31Z

did you try from visual studio or published exe ?
it does not happen when running from visual studio

ghost1372 · 2024-01-10T04:28:36Z

did you try from visual studio or published exe ?
it does not happen when running from visual studio

I tried both visual studio and publish

ghost1372 · 2024-03-15T14:01:02Z

i found another bug
if we collapse NavigationView, then we choose an item, we can not select first item and act as a titlebar drag region

TyJOrtiz · 2024-03-16T20:18:15Z

Is it possible to just adjust the pop up margin?

ghost1372 · 2024-04-22T17:29:47Z

i found another bug if we collapse NavigationView, then we choose an item, we can not select first item and act as a titlebar drag region

This is an expected behavior!
microsoft/microsoft-ui-xaml#9448 (comment)

Arlodotexe · 2024-04-24T00:31:38Z

Looks like this is blocking the CI:

"D:\a\Labs-Windows\Labs-Windows\components\TitleBar\src\CommunityToolkit.WinUI.Controls.TitleBar.csproj" (default target) (21:67) ->
(CoreCompile target) -> 
  D:\a\Labs-Windows\Labs-Windows\components\TitleBar\src\TitleBar.Properties.cs(45,73): error CS1574: XML comment has cref attribute 'Display' that could not be resolved [D:\a\Labs-Windows\Labs-Windows\components\TitleBar\src\CommunityToolkit.WinUI.Controls.TitleBar.csproj::TargetFramework=net7.0-android33.0]

Should be clear to merge once this is resolved.

Arlodotexe

We'd like to close this PR so that iterations and fixes can be done separately, and so that people can start using the experiment from a package in the Labs feed instead of a PR feed.

Arlodotexe · 2024-05-02T16:15:26Z

The current warning in the CI:

"D:\a\Labs-Windows\Labs-Windows\CommunityToolkit.AllComponents.sln" (default target) (1:2) ->
"D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.Uwp\CommunityToolkit.Tests.Uwp.csproj" (default target) (31:6) ->
(CoreCompile target) -> 
  D:\a\Labs-Windows\Labs-Windows\components\TitleBar\tests\ExampleTitleBarTestClass.cs(80,23): error CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.Uwp\CommunityToolkit.Tests.Uwp.csproj]
  D:\a\Labs-Windows\Labs-Windows\components\TitleBar\tests\ExampleTitleBarTestClass.cs(88,23): error CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.Uwp\CommunityToolkit.Tests.Uwp.csproj]
  D:\a\Labs-Windows\Labs-Windows\components\TitleBar\tests\ExampleTitleBarTestClass.cs(95,23): error CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.Uwp\CommunityToolkit.Tests.Uwp.csproj]

Init

0fcb076

niels9001 mentioned this pull request Jul 4, 2023

Gallery design improvements CommunityToolkit/Tooling-Windows-Submodule#88

Merged

ghost1372 mentioned this pull request Jul 4, 2023

Update caption buttons #460

Closed

This comment was marked as resolved.

Sign in to view

niels9001 added 4 commits July 5, 2023 17:10

Remove files

f75784b

Delete BlankPage1.xaml.cs

a39a294

Improve samples

f61434b

XAML styling

7b82a95

UpdateCaptionButtons

cb24ed5

ghost1372 mentioned this pull request Jul 6, 2023

UpdateCaptionButtons #461

Merged

ghost1372 and others added 6 commits July 6, 2023 14:25

Remove GetAppWindow() and Use Window.AppWindow

b4529e4

Merge pull request #462 from ghost1372/TitleBar-AppWindow

8094a33

Remove GetAppWindow() and Use Window.AppWindow

Merge branch 'niels9001/titlebar-experiment' into TitleBar-CaptionBut…

2015162

…tons

Merge pull request #461 from ghost1372/TitleBar-CaptionButtons

3e63cd7

UpdateCaptionButtons

Improve reset

571f33c

Merge branch 'niels9001/titlebar-experiment' of https://github.com/Co…

8f06ff3

…mmunityToolkit/Labs-Windows into niels9001/titlebar-experiment

This comment was marked as outdated.

Sign in to view

Jay-o-Way reviewed Jul 11, 2023

View reviewed changes

components/TitleBar/samples/TitleBar.md Outdated Show resolved Hide resolved

Arlodotexe mentioned this pull request Jul 11, 2023

[Gallery] Move searchbox and menu button to titlebar CommunityToolkit/Tooling-Windows-Submodule#85

Closed

michael-hawker reviewed Jul 11, 2023

View reviewed changes

michael-hawker mentioned this pull request Jan 9, 2024

Upgrade to latest stable WinAppSdk 1.4 #518

Merged

Merge branch 'main' into niels9001/titlebar-experiment

c4d5b38

Merge branch 'main' into niels9001/titlebar-experiment

2cb787e

niels9001 marked this pull request as ready for review April 22, 2024 16:41

Arlodotexe mentioned this pull request Apr 25, 2024

Update TitleBar Control (sync with Labs) CommunityToolkit/Tooling-Windows-Submodule#158

Closed

Fixed nullability errors

cb83879

Arlodotexe enabled auto-merge April 25, 2024 18:04

Arlodotexe approved these changes Apr 25, 2024

View reviewed changes

Arlodotexe added 2 commits April 25, 2024 13:57

Fixed invalid reference in XML comment

4fb3530

Restrict TitleBar MultiTargets to uwp and wasdk

396c61a

Remove empty example test methods

aa780a5

Arlodotexe merged commit 8d49097 into main May 18, 2024
6 of 7 checks passed

delete-merged-branch bot deleted the niels9001/titlebar-experiment branch May 18, 2024 03:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Experiment] TitleBar #459

[Experiment] TitleBar #459

niels9001 commented Jul 4, 2023 •

edited

ghost1372 commented Jul 4, 2023 •

edited

ghost1372 commented Jul 4, 2023

niels9001 commented Jul 4, 2023

This comment was marked as resolved.

dongle-the-gadget commented Jul 6, 2023

Jay-o-Way commented Jul 11, 2023

This comment was marked as outdated.

Jay-o-Way commented Jul 11, 2023

ghost1372 commented Jul 11, 2023 •

edited

Jay-o-Way left a comment

Jay-o-Way commented Jul 11, 2023

niels9001 commented Jul 11, 2023

niels9001 commented Jul 11, 2023

michael-hawker Jul 11, 2023

Jay-o-Way commented Dec 27, 2023

ghost1372 commented Dec 27, 2023

ghost1372 commented Jan 3, 2024

pratikone commented Jan 3, 2024 •

edited

insomniachi commented Jan 9, 2024

ghost1372 commented Jan 9, 2024

insomniachi commented Jan 9, 2024 •

edited

ghost1372 commented Jan 9, 2024

insomniachi commented Jan 9, 2024 •

edited

ghost1372 commented Jan 9, 2024

insomniachi commented Jan 10, 2024

ghost1372 commented Jan 10, 2024

ghost1372 commented Mar 15, 2024 •

edited

TyJOrtiz commented Mar 16, 2024

ghost1372 commented Apr 22, 2024

Arlodotexe commented Apr 24, 2024 •

edited

Arlodotexe left a comment

Arlodotexe commented May 2, 2024

		[DllImport("Shcore.dll", SetLastError = true)]
		internal static extern int GetDpiForMonitor(IntPtr hmonitor, Monitor_DPI_Type dpiType, out uint dpiX, out uint dpiY);

[Experiment] TitleBar #459

[Experiment] TitleBar #459

Conversation

niels9001 commented Jul 4, 2023 • edited

ghost1372 commented Jul 4, 2023 • edited

ghost1372 commented Jul 4, 2023

niels9001 commented Jul 4, 2023

This comment was marked as resolved.

dongle-the-gadget commented Jul 6, 2023

Jay-o-Way commented Jul 11, 2023

This comment was marked as outdated.

Jay-o-Way commented Jul 11, 2023

ghost1372 commented Jul 11, 2023 • edited

Jay-o-Way left a comment

Choose a reason for hiding this comment

Jay-o-Way commented Jul 11, 2023

niels9001 commented Jul 11, 2023

niels9001 commented Jul 11, 2023

michael-hawker Jul 11, 2023

Choose a reason for hiding this comment

Jay-o-Way commented Dec 27, 2023

ghost1372 commented Dec 27, 2023

ghost1372 commented Jan 3, 2024

pratikone commented Jan 3, 2024 • edited

insomniachi commented Jan 9, 2024

ghost1372 commented Jan 9, 2024

insomniachi commented Jan 9, 2024 • edited

ghost1372 commented Jan 9, 2024

insomniachi commented Jan 9, 2024 • edited

ghost1372 commented Jan 9, 2024

insomniachi commented Jan 10, 2024

ghost1372 commented Jan 10, 2024

ghost1372 commented Mar 15, 2024 • edited

TyJOrtiz commented Mar 16, 2024

ghost1372 commented Apr 22, 2024

Arlodotexe commented Apr 24, 2024 • edited

Arlodotexe left a comment

Choose a reason for hiding this comment

Arlodotexe commented May 2, 2024

niels9001 commented Jul 4, 2023 •

edited

ghost1372 commented Jul 4, 2023 •

edited

ghost1372 commented Jul 11, 2023 •

edited

pratikone commented Jan 3, 2024 •

edited

insomniachi commented Jan 9, 2024 •

edited

insomniachi commented Jan 9, 2024 •

edited

ghost1372 commented Mar 15, 2024 •

edited

Arlodotexe commented Apr 24, 2024 •

edited