Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock DataTable on Uno #496

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Martin1994
Copy link

This PR unblocks using DataTable on Uno with a Release build.

The top issue for now is the lack of ListView header in Uno: unoplatform/uno#1979, so this patch introduced a new container without use of a header to unblock its usage on Uno.

This approach is kinda hacky though, so I am looking for discussion about the long term direction assuming ListView's header won't be implemented in Uno soon.

Tested with WinUI 3 and Uno on Skia (WPF and GTK).

data-table

@Martin1994
Copy link
Author

@dotnet-policy-service agree

@michael-hawker
Copy link
Member

Thanks @Martin1994. But yeah, I was trying to explicitly not have an extra layer/type here and just use the natural container found in these scenarios. I believe the Uno folks are working on the issue though with ItemsPresenter? Maybe @MartinZikmund can give an update?

@Martin1994
Copy link
Author

I believe the Uno folks are working on the issue though with ItemsPresenter?

That's great!

If header won't be a blocker, shall we take a look at the change at column resize handler?

// old
CurrentWidth = new(this.ActualWidth);
// new
CurrentWidth = new(this.Width);

When a manipulation event is sent on Uno, I don't see ActualWidth being changed so as a result the column will be frozen at its initial dimension.

@MartinZikmund
Copy link
Contributor

@michael-hawker @Martin1994 On our side @ramezgerges is now working on adding Header and Footer support here unoplatform/uno#13507

@michael-hawker
Copy link
Member

Looks like the PR was merged and the issue closed: unoplatform/uno#10745

Once @Arlodotexe gets Labs up-to-date with our latest changes from the Windows/tooling repos, then we can try the latest Uno version and see how things work with DataTable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants