Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BindableObject Constraint from .Assign() and .Invoke() #131

Merged
merged 4 commits into from
Nov 5, 2022

Conversation

brminnick
Copy link
Collaborator

@brminnick brminnick commented Nov 5, 2022

Description of Change

This PR removes the BindableObject constraint (where T : BindableObject) from .Assign() and .Invoke() extension methods.

Before

public static TBindable Assign<TBindable, TVariable>(this TBindable bindable, out TVariable variable) 
  where TBindable : BindableObject, TVariable;

public static TBindable Invoke<TBindable>(this TBindable bindable, Action<TBindable> action) 
  where TBindable : BindableObject;

After

public static TAssignable Assign<TAssignable, TVariable>(this TAssignable assignable, out TVariable variable) 
  where TAssignable : TVariable;

public static TAssignable Invoke<TAssignable>(this TAssignable assignable, Action<TAssignable> action);
  // no constraint

Linked Issues

PR Checklist

@brminnick brminnick changed the title Open up assign api Remove BindableObject Constraint from .Assign() and .Invoke() Nov 5, 2022
@brminnick brminnick enabled auto-merge (squash) November 5, 2022 21:01
@brminnick brminnick removed the request for review from bijington November 5, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Remove BindableObject Constraint from .Assign() and .Invoke()
3 participants