Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ObjectExtensionsTests to Include Derived Types #136

Merged
merged 4 commits into from
Nov 8, 2022

Conversation

brminnick
Copy link
Collaborator

@brminnick brminnick commented Nov 8, 2022

Description of Change

This PR adds Unit Tests to ObjectExtensionsTests to ensure derived types are supported by .Assign() and .Invoke().

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

Additional information

This PR does not change any code in the CommunityToolkit.Maui.Markup library.

This PR technically, it doesn't "fix" #135. Rather, it confirms that we cannot reproduce #135.

This PR also adds <WarningsAsErrors>CS1710</WarningsAsErrors> to avoid duplicate XML Comments

@brminnick brminnick enabled auto-merge (squash) November 8, 2022 18:29
Copy link
Contributor

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@brminnick brminnick merged commit 3ef9b97 into main Nov 8, 2022
@brminnick brminnick deleted the Add-Unit-Tests-for-ObjectExtensions branch November 8, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] .Assign Extension does not work with inherited controls of Label and Entry
2 participants