Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods for remaining VisualElement properties #141

Merged

Conversation

mrlacey
Copy link
Contributor

@mrlacey mrlacey commented Nov 10, 2022

For discussion #140

Description of Change

Add methods for properties of VisualElement that do not yet have them.

Also updates the Sample app to use these new methods (where appropriate).
Also fixes the image not displaying on the sample app settings page.

Linked Issues

PR Checklist

Additional information

mrlacey added a commit to mrlacey/CommunityToolkit that referenced this pull request Nov 10, 2022
@mrlacey mrlacey marked this pull request as ready for review November 10, 2022 13:15
pictos
pictos previously requested changes Nov 10, 2022
Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mrlacey thanks for your PR! I've one request, let me know what do you think

@brminnick
Copy link
Collaborator

Thanks @mrlacey!

Before we can merge this PR, there's a couple procedural steps we first need to do:

  1. Submit a New Feature Proposal
  2. Get Approval Vote from Core Maintainer Team

When you get a chance, go ahead and open a Proposal. Then, I'll bring this Visual Element Proposal to a vote at our next monthly standup.

We have some more info in the README about the new feature process. It's a bit of a pain, but it ensures that every new feature we add is super high quality (which this one looks to be!).
https://github.com/CommunityToolkit/Maui.Markup#submitting-a-new-feature

Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @mrlacey!!

@brminnick brminnick enabled auto-merge (squash) December 6, 2022 21:20
@brminnick brminnick dismissed pictos’s stale review December 6, 2022 22:59

Discussed Source Generators on December 2022 Standup

@brminnick brminnick merged commit 2b48f08 into CommunityToolkit:main Dec 6, 2022
jfversluis pushed a commit to MicrosoftDocs/CommunityToolkit that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Add methods for all VisualElement Properties
4 participants