-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods for remaining VisualElement properties #141
Add methods for remaining VisualElement properties #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mrlacey thanks for your PR! I've one request, let me know what do you think
Thanks @mrlacey! Before we can merge this PR, there's a couple procedural steps we first need to do:
When you get a chance, go ahead and open a Proposal. Then, I'll bring this Visual Element Proposal to a vote at our next monthly standup. We have some more info in the README about the new feature process. It's a bit of a pain, but it ensures that every new feature we add is super high quality (which this one looks to be!). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @mrlacey!!
Discussed Source Generators on December 2022 Standup
For discussion #140
Description of Change
Add methods for properties of VisualElement that do not yet have them.
Also updates the Sample app to use these new methods (where appropriate).
Also fixes the image not displaying on the sample app settings page.
Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information