Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tizen TFM to Sample #146

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Conversation

JoonghyunCho
Copy link
Member

@JoonghyunCho JoonghyunCho commented Nov 14, 2022

Description of Change

This PR adds Tizen support on Maui Markup Sample!
Tizen Workload is not included in the default MAUI Workloads, so it will break unless you install the Tizen Workload.
Therefore, TF_BUILD condition is set for adding net7.0-tizen as the TargetFrameworks so it is only included in the CI environment where Tizen workload environment is prepared.

Linked Issues

PR Checklist

Additional information

@brminnick
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@brminnick
Copy link
Collaborator

Strange - I don't see the Azure Pipelines running.

Did the YAML get scrogged in azure-pipelines.yaml? Like, a rogue spacing/indentation in the YAML?

@JoonghyunCho
Copy link
Member Author

@brminnick sorry for that.. indentation in yaml..

@brminnick
Copy link
Collaborator

Gosh darn YAML... 😆

The best tool I've found to avoid YAML parsing errors is this Visual Studio Code plugin. It's a YAML linter.

It's pretty good. It doesn't catch every possible YAML bug, but it detects a lot of them.

https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml

@JoonghyunCho
Copy link
Member Author

@brminnick Thanks for sharing! I think I should have the extenion. 😆

@brminnick brminnick enabled auto-merge (squash) November 14, 2022 16:42
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jay!!

@brminnick brminnick merged commit 9d60531 into CommunityToolkit:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sample App] Add Tizen to CommunityToolkit.Maui.Markup.Sample
2 participants